Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6bcac4c7 authored by Steven Moreland's avatar Steven Moreland Committed by Android (Google) Code Review
Browse files

Merge "RPC Binder: log transaction failures" into main

parents 98e96d91 bc5f64fb
Loading
Loading
Loading
Loading
+10 −1
Original line number Diff line number Diff line
@@ -538,7 +538,16 @@ status_t RpcState::transact(const sp<RpcSession::RpcConnection>& connection,
    uint64_t address;
    if (status_t status = onBinderLeaving(session, binder, &address); status != OK) return status;

    return transactAddress(connection, address, code, data, session, reply, flags);
    if (status_t status = transactAddress(connection, address, code, data, session, reply, flags);
        status != OK) {
        // TODO(b/414720799): this log is added to debug this bug, but it could be a bit noisy, and
        // we may only want to log it from some cases moving forward.
        ALOGE("RPC protocol error during call to binder: %p code: %" PRIu32 " transaction: %s",
              binder.get(), code, statusToString(status).c_str());
        return status;
    }

    return OK;
}

status_t RpcState::transactAddress(const sp<RpcSession::RpcConnection>& connection,