Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 366eb423 authored by Steven Moreland's avatar Steven Moreland
Browse files

Use binder rather than kernel ONEWAY flag. 

FLAG_ONEWAY is defined by IBinder, but TF_ONE_WAY is defined by the
binder kernel. These both have the value '1'.

In order to remove the binder kernel headers as an export of libbinder,
FLAG_ONEWAY should be used.

Bug: 124524556
Test: N/A
Change-Id: If71673b3bd4f41e34316c39e2139a9e39912dd23
parent 72051fdd

libs/gui/IGraphicBufferProducer.cpp

+1 −1
Original line number Diff line number Diff line
@@ -355,7 +355,7 @@ public: 
        data.writeUint32(height);

        data.writeInt32(static_cast<int32_t>(format));

        data.writeUint64(usage);

        status_t result = remote()->transact(ALLOCATE_BUFFERS, data, &reply, TF_ONE_WAY);

        status_t result = remote()->transact(ALLOCATE_BUFFERS, data, &reply, IBinder::FLAG_ONEWAY);

        if (result != NO_ERROR) {

            ALOGE("allocateBuffers failed to transact: %d", result);

        }

libs/gui/ISurfaceComposer.cpp

+4 −3
Original line number Diff line number Diff line
@@ -504,8 +504,8 @@ public: 
            ALOGE("enableVSyncInjections failed to writeBool: %d", result);

            return result;

        }

        result = remote()->transact(BnSurfaceComposer::ENABLE_VSYNC_INJECTIONS,

                data, &reply, TF_ONE_WAY);

        result = remote()->transact(BnSurfaceComposer::ENABLE_VSYNC_INJECTIONS, data, &reply,

                                    IBinder::FLAG_ONEWAY);

        if (result != NO_ERROR) {

            ALOGE("enableVSyncInjections failed to transact: %d", result);

            return result;
@@ -525,7 +525,8 @@ public: 
            ALOGE("injectVSync failed to writeInt64: %d", result);

            return result;

        }

        result = remote()->transact(BnSurfaceComposer::INJECT_VSYNC, data, &reply, TF_ONE_WAY);

        result = remote()->transact(BnSurfaceComposer::INJECT_VSYNC, data, &reply,

                                    IBinder::FLAG_ONEWAY);

        if (result != NO_ERROR) {

            ALOGE("injectVSync failed to transact: %d", result);

            return result;