Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cc32ecc5 authored by TreeHugger Robot's avatar TreeHugger Robot Committed by Android (Google) Code Review
Browse files

Merge "Check for null layer handles from clients"

parents 54cf5f41 dc6f5b98
Loading
Loading
Loading
Loading
+7 −1
Original line number Original line Diff line number Diff line
@@ -3129,7 +3129,13 @@ uint32_t SurfaceFlinger::setClientStateLocked(
        listenerCallbacks.insert(listener);
        listenerCallbacks.insert(listener);
    }
    }


    sp<Layer> layer(fromHandle(s.surface));
    sp<Layer> layer = nullptr;
    if (s.surface) {
        layer = fromHandle(s.surface);
    } else {
        // The client may provide us a null handle. Treat it as if the layer was removed.
        ALOGW("Attempt to set client state with a null layer handle");
    }
    if (layer == nullptr) {
    if (layer == nullptr) {
        for (auto& [listener, callbackIds] : s.listeners) {
        for (auto& [listener, callbackIds] : s.listeners) {
            mTransactionCompletedThread.registerUnpresentedCallbackHandle(
            mTransactionCompletedThread.registerUnpresentedCallbackHandle(