Commit c684560d authored Apr 07, 2016 by Chia-I Wu

vulkan: avoid double-free in InitSharedPtr

When std::shared_ptr fails to allocate its internal data, it deletes the
managed object automatically.  We should not call obj->common.decRef on
std::bad_alloc.

Bug: 28039233
Change-Id: I1fe00c16e83e426602eac96d8b86afb4fd4830e6

parent 79632ee4

vulkan/libvulkan/swapchain.cpp

+0 −1

Original line number	Diff line number	Diff line
		@@ -102,7 +102,6 @@ std::shared_ptr<T> InitSharedPtr(Host host, T* obj) {
		obj, NativeBaseDeleter<T>(),
		VulkanAllocator<T>(*GetAllocator(host), AllocScope<Host>::kScope));
		} catch (std::bad_alloc&) {
		obj->common.decRef(&obj->common);
		return nullptr;
		}
		}