Correct assertNotifyMotionWasNotCalled check
Currently, we have the wrong check for whether notifyMotion was not called. We should be checking the NotifyMotionArgs, not NotifySwitchArgs. Changing it to "motion" makes 3 tests fail: [245/253] MultiTouchInputMapperTest_SurfaceRange#Viewports_SurfaceRange: FAILED (0ms) STACKTRACE: frameworks/native/services/inputflinger/tests/TestInputListener.cpp:121: Failure Failed Unexpected event: notifyMotion() should not be called. frameworks/native/services/inputflinger/tests/TestInputListener.cpp:74: Failure Expected: assertNotCalled<NotifyMotionArgs>("notifyMotion() should not be called.") doesn't generate new fatal failures in the current thread. Actual: it does. frameworks/native/services/inputflinger/tests/InputReader_test.cpp:7730: Failure Expected: mFakeListener->assertNotifyMotionWasNotCalled() doesn't generate new fatal failures in the current thread. Actual: it does. [246/253] MultiTouchInputMapperTest_SurfaceRange#Viewports_SurfaceRange_90: FAILED (1ms) STACKTRACE: frameworks/native/services/inputflinger/tests/TestInputListener.cpp:121: Failure Failed Unexpected event: notifyMotion() should not be called. frameworks/native/services/inputflinger/tests/TestInputListener.cpp:74: Failure Expected: assertNotCalled<NotifyMotionArgs>("notifyMotion() should not be called.") doesn't generate new fatal failures in the current thread. Actual: it does. frameworks/native/services/inputflinger/tests/InputReader_test.cpp:7730: Failure Expected: mFakeListener->assertNotifyMotionWasNotCalled() doesn't generate new fatal failures in the current thread. Actual: it does. [247/253] MultiTouchInputMapperTest_SurfaceRange#Viewports_SurfaceRange_270: FAILED (0ms) STACKTRACE: frameworks/native/services/inputflinger/tests/TestInputListener.cpp:121: Failure Failed Unexpected event: notifyMotion() should not be called. frameworks/native/services/inputflinger/tests/TestInputListener.cpp:74: Failure Expected: assertNotCalled<NotifyMotionArgs>("notifyMotion() should not be called.") doesn't generate new fatal failures in the current thread. Actual: it does. frameworks/native/services/inputflinger/tests/InputReader_test.cpp:7730: Failure Expected: mFakeListener->assertNotifyMotionWasNotCalled() doesn't generate new fatal failures in the current thread. Actual: it does. Temporarily disable these tests. Bug: 172240848 Test: atest inputflinger_tests Change-Id: I86ff65728b38d8cb75d786c46dafeaa9b75b10f3
Loading
Please register or sign in to comment