Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 93e554f9 authored by Corey Tabaka's avatar Corey Tabaka
Browse files

libpdx_uds: Fix uninitialized variable bug. 

In this code path epoll_wait() returns 0 when the operation times
out, but there is no condition to catch this and return the
approptiate status. This allows the event value to be used
uninitialized, which returns a junk pending event mask.

This bug results in BufferHub queues sometimes thinking that the
producer side of the buffer hung up, when the junk value happens
to have the EPOLLHUP bit set.

Bug: 62886596
Test: Observe VR app switching stability.
Change-Id: Id9554d6bf224fd27815ff042ac145f59041d0aae
parent d5547979

libs/vr/libpdx_uds/channel_event_set.cpp

+3 −0
Original line number Diff line number Diff line
@@ -100,6 +100,9 @@ Status<int> ChannelEventReceiver::GetPendingEvents() const { 
    ALOGE("ChannelEventReceiver::GetPendingEvents: Failed to get events: %s",

          status.GetErrorMessage().c_str());

    return status;

  } else if (count == 0) {

    status.SetError(ETIMEDOUT);

    return status;

  }



  const int mask_out = event.data.u32;