Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content
Commit 1c67880b authored by Steven Moreland's avatar Steven Moreland
Browse files

binderRpcTest: fix OnewayCallQueueing flake

This was a problem very rarely because we were introducing an extra 50ms
delay, so a device had to be really slow in order to hit this. Anyway,
if this test client was getting descheduled, since the time it took to
issue oneway calls was discounted from our measurement of the server
time, we could report the server returning too early.

Now we include dispatch in this time, and the 50ms range is discounted.
Note, this also means that this particular test would no longer tell us
if oneway calls were accidentally serial. However, there are other tests
which check this (such as OnewayCallDoesNotWait, which can be modified
easily to support arbitrarily slow devices, even though it is
technically also race prone).

Bug: 200173589
Test: looping: binderRpcTest --gtest_filter="*OnewayCallQueu*"
Change-Id: Ie8e270c480790ceb53809279e8d2265a88fa4cb5
parent 22a54f6a
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment