Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ff40e01e authored by Mady Mellor's avatar Mady Mellor
Browse files

Fix dialer bubbles not bubbling / remove alertAgain logic 

I had carried this in from notification alert logic but looking at it
more closely it seems not appropriate here (maybe appropriate / something
to incorporate for the flyout?)

Dialer has a notification when the phone call comes in and then when you
leave the phone activity they update that notification to bubble, the
alertAgain logic was filtering this update out.

Test: manual with dialer APK - get a phone call, leave the phone call
      activity, note that a bubble is displayed on screen
Bug: 131252815

Change-Id: I05bff55863b5dd40037741c133eea30397c11b58
parent 48f289fe

packages/SystemUI/src/com/android/systemui/bubbles/BubbleController.java

+1 −2
Original line number Original line Diff line number Diff line
@@ -27,7 +27,6 @@ import static android.view.View.VISIBLE; 
import static android.view.ViewGroup.LayoutParams.MATCH_PARENT;

import static android.view.ViewGroup.LayoutParams.MATCH_PARENT;





import static com.android.systemui.statusbar.StatusBarState.SHADE;

import static com.android.systemui.statusbar.StatusBarState.SHADE;

import static com.android.systemui.statusbar.notification.NotificationAlertingManager.alertAgain;





import static java.lang.annotation.RetentionPolicy.SOURCE;

import static java.lang.annotation.RetentionPolicy.SOURCE;
@@ -464,7 +463,7 @@ public class BubbleController implements ConfigurationController.ConfigurationLi 
            if (!shouldBubble && mBubbleData.hasBubbleWithKey(entry.key)) {

            if (!shouldBubble && mBubbleData.hasBubbleWithKey(entry.key)) {

                // It was previously a bubble but no longer a bubble -- lets remove it

                // It was previously a bubble but no longer a bubble -- lets remove it

                removeBubble(entry.key, DISMISS_NO_LONGER_BUBBLE);

                removeBubble(entry.key, DISMISS_NO_LONGER_BUBBLE);

            } else if (shouldBubble && alertAgain(entry, entry.notification.getNotification())) {

            } else if (shouldBubble) {

                updateShowInShadeForSuppressNotification(entry);

                updateShowInShadeForSuppressNotification(entry);

                entry.setBubbleDismissed(false); // updates come back as bubbles even if dismissed

                entry.setBubbleDismissed(false); // updates come back as bubbles even if dismissed

                updateBubble(entry);

                updateBubble(entry);