Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f82f5ede authored by Nan Wu's avatar Nan Wu
Browse files

Fix collect extra intent keys on server.

There are 2 issues:
1. in order to improve performance, we only collect keys on server
   if the extra bundle contains intent. This was indicated with a
   bit flag stored in BaseBundle.mFlags. However, the field mFlags
   is not parceled/unparceled. So that won't work - the flag is turned on on the client side and checked on the
   server side. To fix it, use a boolean member and parcel it.
2. This bug is discovered when investigating b/377190225. We found
   out that in collectNestedIntenKeysRecur, the intent was marked
   as keys are collected before it actually collects it. A recent
   change (do not unparcel a bundle when collecting keys) means
   calling this method may not have collected keys if the bundle is
   parceled. The fix is to move the line below after the bundle is
   unparceled.

Bug: 377190225
Test: manual
Flag: EXEMPT bug fix
Change-Id: I645ded2f1e3422c9297962da47f93ca59f6f0b55
parent c7bd665f
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment