Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f791b69d authored by Eric Laurent's avatar Eric Laurent
Browse files

AudioDeviceBroker: remove unnecessary synchronization around onUpdatedAdiDeviceState 

Commit e1dae84f introduced a potential cross deadlock between
AudioDeviceBroker and SpatializerHelper.
Removing the unnecessary synchronization on mDeviceStateLock before
calling AudioService.onUpdatedAdiDeviceState() fixes it.

Bug: 315434689
Test: build and make.
Change-Id: I97fadfa82a2c21a18a5ce14dee29774a62bd2696
parent 54b89873

services/core/java/com/android/server/audio/AudioDeviceBroker.java

+2 −3
Original line number Diff line number Diff line
@@ -2037,9 +2037,8 @@ public class AudioDeviceBroker { 
                    } break;



                case MSG_L_UPDATED_ADI_DEVICE_STATE:

                    synchronized (mDeviceStateLock) {

                    mAudioService.onUpdatedAdiDeviceState((AdiDeviceState) msg.obj);

                    } break;

                    break;



                default:

                    Log.wtf(TAG, "Invalid message " + msg.what);