Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f4e1d98c authored by mattgilbride's avatar mattgilbride
Browse files

Baseline remaining SimpleManualPermissionEnforcement lint errors 

The subject linter catches cases that would be trivial to
migrate from manual permission checks to the @EnforcePermission
annotation. The linter will soon raise an error in the
errorprone build if such a change would be completely
behavior preserving, and thus the manual permission check
should be replaced by the annotation.

Baseline the remaining sites that would raise such an error
so that the linter can be updated accordingly.

Bug: 265014041
Test: TH, manually tested with local changes to linter
Change-Id: I7932f75b2dbd96944fee63d36e15529df3219d3a
parent 5ea15609

services/accessibility/lint-baseline.xml

0 → 100644
+26 −0
Original line number Diff line number Diff line 
<?xml version="1.0" encoding="UTF-8"?>

<issues format="6" by="lint 8.1.0-dev" type="baseline" client="" dependencies="true" name="" variant="all" version="8.1.0-dev">



    <issue

        id="SimpleManualPermissionEnforcement"

        message="IAccessibilityManager permission check should be converted to @EnforcePermission annotation"

        errorLine1="        mContext.enforceCallingOrSelfPermission("

        errorLine2="        ^">

        <location

            file="frameworks/base/services/accessibility/java/com/android/server/accessibility/AccessibilityManagerService.java"

            line="3992"

            column="9"/>

    </issue>



    <issue

        id="SimpleManualPermissionEnforcement"

        message="IAccessibilityManager permission check should be converted to @EnforcePermission annotation"

        errorLine1="        mContext.enforceCallingOrSelfPermission("

        errorLine2="        ^">

        <location

            file="frameworks/base/services/accessibility/java/com/android/server/accessibility/AccessibilityManagerService.java"

            line="4007"

            column="9"/>

    </issue>



</issues>

services/backup/lint-baseline.xml

+24 −0
Original line number Diff line number Diff line
@@ -12,4 +12,28 @@ 
            column="16"/>

    </issue>



    <issue

        id="SimpleManualPermissionEnforcement"

        message="IRestoreSession permission check should be converted to @EnforcePermission annotation">

        <location

            file="frameworks/base/services/backup/java/com/android/server/backup/restore/ActiveRestoreSession.java"

            line="88"/>

    </issue>



    <issue

        id="SimpleManualPermissionEnforcement"

        message="IRestoreSession permission check should be converted to @EnforcePermission annotation">

        <location

            file="frameworks/base/services/backup/java/com/android/server/backup/restore/ActiveRestoreSession.java"

            line="144"/>

    </issue>



    <issue

        id="SimpleManualPermissionEnforcement"

        message="IRestoreSession permission check should be converted to @EnforcePermission annotation">

        <location

            file="frameworks/base/services/backup/java/com/android/server/backup/restore/ActiveRestoreSession.java"

            line="207"/>

    </issue>



</issues>

services/core/lint-baseline.xml

+8 −0
Original line number Diff line number Diff line
@@ -137,4 +137,12 @@ 
            line="1448"/>

    </issue>



    <issue

        id="SimpleManualPermissionEnforcement"

        message="IWindowManager permission check should be converted to @EnforcePermission annotation">

        <location

            file="out/.intermediates/frameworks/base/services/core/services.core.protologsrc/gen/services.core.protolog.srcjar!/frameworks/base/services/core/java/com/android/server/wm/WindowManagerService.java"

            line="7158"/>

    </issue>



</issues>

services/lint-baseline.xml

0 → 100644
+59 −0
Original line number Diff line number Diff line 
<?xml version="1.0" encoding="UTF-8"?>

<issues format="6" by="lint 8.1.0-dev" type="baseline" client="" dependencies="true" name="" variant="all" version="8.1.0-dev">



    <issue

        id="SimpleManualPermissionEnforcement"

        message="ISystemConfig permission check should be converted to @EnforcePermission annotation"

        errorLine1="            mContext.enforceCallingOrSelfPermission(Manifest.permission.READ_CARRIER_APP_INFO,"

        errorLine2="            ^">

        <location

            file="frameworks/base/services/java/com/android/server/SystemConfigService.java"

            line="46"

            column="13"/>

    </issue>



    <issue

        id="SimpleManualPermissionEnforcement"

        message="ISystemConfig permission check should be converted to @EnforcePermission annotation"

        errorLine1="            mContext.enforceCallingOrSelfPermission(Manifest.permission.READ_CARRIER_APP_INFO,"

        errorLine2="            ^">

        <location

            file="frameworks/base/services/java/com/android/server/SystemConfigService.java"

            line="54"

            column="13"/>

    </issue>



    <issue

        id="SimpleManualPermissionEnforcement"

        message="ISystemConfig permission check should be converted to @EnforcePermission annotation"

        errorLine1="            mContext.enforceCallingOrSelfPermission(Manifest.permission.READ_CARRIER_APP_INFO,"

        errorLine2="            ^">

        <location

            file="frameworks/base/services/java/com/android/server/SystemConfigService.java"

            line="67"

            column="13"/>

    </issue>



    <issue

        id="SimpleManualPermissionEnforcement"

        message="ISystemConfig permission check should be converted to @EnforcePermission annotation"

        errorLine1="            mContext.enforceCallingOrSelfPermission(Manifest.permission.GET_RUNTIME_PERMISSIONS,"

        errorLine2="            ^">

        <location

            file="frameworks/base/services/java/com/android/server/SystemConfigService.java"

            line="76"

            column="13"/>

    </issue>



    <issue

        id="SimpleManualPermissionEnforcement"

        message="ISystemConfig permission check should be converted to @EnforcePermission annotation"

        errorLine1="            getContext().enforceCallingOrSelfPermission(Manifest.permission.QUERY_ALL_PACKAGES,"

        errorLine2="            ^">

        <location

            file="frameworks/base/services/java/com/android/server/SystemConfigService.java"

            line="107"

            column="13"/>

    </issue>



</issues>

services/print/lint-baseline.xml

0 → 100644
+15 −0
Original line number Diff line number Diff line 
<?xml version="1.0" encoding="UTF-8"?>

<issues format="6" by="lint 8.1.0-dev" type="baseline" client="" dependencies="true" name="" variant="all" version="8.1.0-dev">



    <issue

        id="SimpleManualPermissionEnforcement"

        message="IPrintManager permission check should be converted to @EnforcePermission annotation"

        errorLine1="            mContext.enforceCallingOrSelfPermission("

        errorLine2="            ^">

        <location

            file="frameworks/base/services/print/java/com/android/server/print/PrintManagerService.java"

            line="401"

            column="13"/>

    </issue>



</issues>