Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ee41d4af authored by Wale Ogunwale's avatar Wale Ogunwale
Browse files

Introduced WindowContainer.mConsumerWrapperPool 

WindowContainer.forAllWindows(Consumer<WindowState>...) requires a lambda
to be allocated each time it is called since we need to capture the callback.
Switched to using an object pool for the process to reduce allocations.

Test: Run the allocation traker and make sure there aren't lambda allocations
      for WindowContainer.forAllWindows() method.
Change-Id: If49c1b0bd2e0a5d6d7a30ff686b5235e69a61750
parent 6213caa4

services/core/java/com/android/server/wm/WindowContainer.java

+36 −4
Original line number Diff line number Diff line
@@ -18,6 +18,8 @@ package com.android.server.wm; 


import android.annotation.CallSuper;

import android.content.res.Configuration;

import android.util.Pools;



import com.android.internal.util.ToBooleanFunction;



import java.util.Comparator;
@@ -68,6 +70,9 @@ class WindowContainer<E extends WindowContainer> implements Comparable<WindowCon 
    // The specified orientation for this window container.

    protected int mOrientation = SCREEN_ORIENTATION_UNSPECIFIED;



    private final Pools.SynchronizedPool<ForAllWindowsConsumerWrapper> mConsumerWrapperPool =

            new Pools.SynchronizedPool<>(3);



    final protected WindowContainer getParent() {

        return mParent;

    }
@@ -517,10 +522,9 @@ class WindowContainer<E extends WindowContainer> implements Comparable<WindowCon 
    }



    void forAllWindows(Consumer<WindowState> callback, boolean traverseTopToBottom) {

        forAllWindows(w -> {

            callback.accept(w);

            return false;

        }, traverseTopToBottom);

        ForAllWindowsConsumerWrapper wrapper = obtainConsumerWrapper(callback);

        forAllWindows(wrapper, traverseTopToBottom);

        wrapper.release();

    }



    WindowState getWindow(Predicate<WindowState> callback) {
@@ -613,4 +617,32 @@ class WindowContainer<E extends WindowContainer> implements Comparable<WindowCon 
        return toString();

    }



    private ForAllWindowsConsumerWrapper obtainConsumerWrapper(Consumer<WindowState> consumer) {

        ForAllWindowsConsumerWrapper wrapper = mConsumerWrapperPool.acquire();

        if (wrapper == null) {

            wrapper = new ForAllWindowsConsumerWrapper();

        }

        wrapper.setConsumer(consumer);

        return wrapper;

    }



    private final class ForAllWindowsConsumerWrapper implements ToBooleanFunction<WindowState> {



        private Consumer<WindowState> mConsumer;



        void setConsumer(Consumer<WindowState> consumer) {

            mConsumer = consumer;

        }



        @Override

        public boolean apply(WindowState w) {

            mConsumer.accept(w);

            return false;

        }



        void release() {

            mConsumer = null;

            mConsumerWrapperPool.release(this);

        }

    }

}