Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit eacba4ed authored by Alejandro Nijamkin's avatar Alejandro Nijamkin
Browse files

[flexiglass] destinationScenes a stable flow. 

Changes destinationScenes from fun to val but, more importantly, changes
all implementations to return a constant value for the flow. For
implementations that return a more complex Flow, this doesn't change
anything but for those that return a newly constructed MutableStateFlow,
it prevents each property read from instantiating a new MutableStateFlow
copy.

Fix: 300915579
Test: moved between scenes in Flexiglass, visited all scenes except
Communal

Change-Id: I9ef5a7d9fc1c665909e3e5e600e18057d0058887
parent 549a4c3e

packages/SystemUI/compose/features/src/com/android/systemui/bouncer/ui/composable/BouncerScene.kt

+1 −1
Original line number Diff line number Diff line
@@ -82,7 +82,7 @@ constructor( 
) : ComposableScene {

    override val key = SceneKey.Bouncer



    override fun destinationScenes(): StateFlow<Map<UserAction, SceneModel>> =

    override val destinationScenes: StateFlow<Map<UserAction, SceneModel>> =

        MutableStateFlow(

                mapOf(

                    UserAction.Back to SceneModel(SceneKey.Lockscreen),

packages/SystemUI/compose/features/src/com/android/systemui/keyguard/ui/composable/LockscreenScene.kt

+2 −2
Original line number Diff line number Diff line
@@ -66,13 +66,13 @@ constructor( 
) : ComposableScene {

    override val key = SceneKey.Lockscreen



    override fun destinationScenes(): StateFlow<Map<UserAction, SceneModel>> =

    override val destinationScenes: StateFlow<Map<UserAction, SceneModel>> =

        viewModel.upDestinationSceneKey

            .map { pageKey -> destinationScenes(up = pageKey) }

            .stateIn(

                scope = applicationScope,

                started = SharingStarted.Eagerly,

                initialValue = destinationScenes(up = null)

                initialValue = destinationScenes(up = viewModel.upDestinationSceneKey.value)

            )



    @Composable

packages/SystemUI/compose/features/src/com/android/systemui/qs/ui/composable/QuickSettingsScene.kt

+2 −1
Original line number Diff line number Diff line
@@ -58,13 +58,14 @@ constructor( 
) : ComposableScene {

    override val key = SceneKey.QuickSettings



    override fun destinationScenes(): StateFlow<Map<UserAction, SceneModel>> =

    private val _destinationScenes =

        MutableStateFlow<Map<UserAction, SceneModel>>(

                mapOf(

                    UserAction.Swipe(Direction.UP) to SceneModel(SceneKey.Shade),

                )

            )

            .asStateFlow()

    override val destinationScenes: StateFlow<Map<UserAction, SceneModel>> = _destinationScenes



    @Composable

    override fun SceneScope.Content(

packages/SystemUI/compose/features/src/com/android/systemui/scene/ui/composable/GoneScene.kt

+1 −1
Original line number Diff line number Diff line
@@ -38,7 +38,7 @@ import kotlinx.coroutines.flow.asStateFlow 
class GoneScene @Inject constructor() : ComposableScene {

    override val key = SceneKey.Gone



    override fun destinationScenes(): StateFlow<Map<UserAction, SceneModel>> =

    override val destinationScenes: StateFlow<Map<UserAction, SceneModel>> =

        MutableStateFlow<Map<UserAction, SceneModel>>(

                mapOf(

                    UserAction.Swipe(Direction.DOWN) to SceneModel(SceneKey.Shade),

packages/SystemUI/compose/features/src/com/android/systemui/scene/ui/composable/SceneContainer.kt

+2 −2
Original line number Diff line number Diff line
@@ -79,7 +79,7 @@ fun SceneContainer( 
    val currentSceneKey = currentSceneModel.key

    val currentScene = checkNotNull(sceneByKey[currentSceneKey])

    val currentDestinations: Map<UserAction, SceneModel> by

        currentScene.destinationScenes().collectAsState()

        currentScene.destinationScenes.collectAsState()

    val state = remember { SceneTransitionLayoutState(currentSceneKey.toTransitionSceneKey()) }

    val isRibbonEnabled = remember { SystemProperties.getBoolean("flexi.ribbon", false) }
@@ -116,7 +116,7 @@ fun SceneContainer( 
                        if (sceneKey == currentSceneKey) {

                                currentDestinations

                            } else {

                                composableScene.destinationScenes().value

                                composableScene.destinationScenes.value

                            }

                            .map { (userAction, destinationSceneModel) ->

                                toTransitionModels(userAction, destinationSceneModel)