Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e90f7753 authored by Ats Jenk's avatar Ats Jenk
Browse files

Override hashCode in AnimatableScaleMatrix

This class is used in PhysicsAnimator as a key in a hashmap. We already
override equals, also override hashCode for it to have matching
behavior.

Bug: 349845968
Test: atest WMShellRobolectricTests:com.android.wm.shell.bubbles.animation.AnimatableScaleMatrixTest
Test: atest  WMShellMultivalentTestsOnDevice:com.android.wm.shell.bubbles.animation.AnimatableScaleMatrixTest
Flag: EXEMPT bugfix
Change-Id: I56625f616426e3aa01d3c413de45a6f340c7f018
parent b34540fe
Loading
Loading
Loading
Loading
+53 −0
Original line number Diff line number Diff line
/*
 * Copyright (C) 2024 The Android Open Source Project
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *      http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

package com.android.wm.shell.bubbles.animation

import androidx.test.ext.junit.runners.AndroidJUnit4
import androidx.test.filters.SmallTest
import com.google.common.truth.Truth.assertThat
import org.junit.Test
import org.junit.runner.RunWith

/** Tests for [AnimatableScaleMatrix] */
@SmallTest
@RunWith(AndroidJUnit4::class)
class AnimatableScaleMatrixTest {

    @Test
    fun test_equals_matricesWithSameValuesAreNotEqual() {
        val matrix1 = AnimatableScaleMatrix().apply { setScale(0.5f, 0.5f) }
        val matrix2 = AnimatableScaleMatrix().apply { setScale(0.5f, 0.5f) }
        assertThat(matrix1).isNotEqualTo(matrix2)
    }

    @Test
    fun test_hashCode_remainsSameIfMatrixUpdates() {
        val matrix = AnimatableScaleMatrix().apply { setScale(0.5f, 0.5f) }
        val hash1 = matrix.hashCode()
        matrix.setScale(0.75f, 0.75f)
        val hash2 = matrix.hashCode()

        assertThat(hash1).isEqualTo(hash2)
    }

    @Test
    fun test_hashCode_matricesWithSameValuesHaveDiffHashCode() {
        val matrix1 = AnimatableScaleMatrix().apply { setScale(0.5f, 0.5f) }
        val matrix2 = AnimatableScaleMatrix().apply { setScale(0.5f, 0.5f) }
        assertThat(matrix1.hashCode()).isNotEqualTo(matrix2.hashCode())
    }
}
+6 −0
Original line number Diff line number Diff line
@@ -141,4 +141,10 @@ public class AnimatableScaleMatrix extends Matrix {
        // PhysicsAnimator's animator caching).
        return obj == this;
    }

    @Override
    public int hashCode() {
        // Make sure equals and hashCode work in a similar way. Rely on object identity for both.
        return System.identityHashCode(this);
    }
}