Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content
Commit e509515e authored by Evan Laird's avatar Evan Laird Committed by Cherrypicker Worker
Browse files

[StatusBar] Request layout on vis change, and move to CREATED

The flow that was being bound to the mobile icon group's visibility
lived in STARTED (this caused tests to pass). It also was experiencing a
race condition against the StatusIconContainer. In certain
circumstances, the view was being created and sent to have an icon state
of HIDDEN, despite having changed itself to be VISIBLE.

This is all emergent behavior from StatusIconContainer, which decides
which state to set on icons in its onMeasure(), but then applies that
state in onLayout().

To test: remove battery percent from status bar; ensure that _no other
icon_ is showing. This means disable Wi-Fi and make sure volume is set
to vibrate or on, since those states have no icon. Once you are in a
state where there is only battery and mobile showing, remove and
re-insert the SIM card to reproduce.

Test: ModernStatusBarMobileViewTest
Test: manually removing and inserting SIM card
Fixes: 291031862
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:53657d1ff8ba10647c38d8ad5fd0486202b2dedd)
Merged-In: I0e68037126a526fcf3614bf25683af3fa4e5aa96
Change-Id: I0e68037126a526fcf3614bf25683af3fa4e5aa96
parent f353aecc
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment