Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content
Commit e4a15a4d authored by Jeff DeCew's avatar Jeff DeCew
Browse files

New Pipeline: Fix minimized notifications not appearing minimized.

* The bug was that the LowPriorityInflationHelper checks the parent after a delay to inflate an empty ExpandableNotificationRow, by which time the ListEntry's parent was cleared by the FinalizeFilter.  In order to solve this, we need to pass state into the inflation pipeline for this particular parameter.  I created the NotifInflater.Params class to hold this, and then shoehorned that class into the not-yet-modernized NotificationRowBinder interface/impl.
* Another bug I discovered when looking for params like this was that a ranking update (such as the addition of SmartReplies) would not result in reinflating the notification, because the system had no way to detect that a ranking update would affect the view itself.  This is why I added the NotifUiAdjustment class (copied, kotlinized, and tweaked to include the 'minimized' state from the NotificationUiAdjustment).

Fixes: 205360544
Test: atest SystemUITests
Change-Id: Ic1aa2dded98b14efe0219684aa754549d9d53d81
parent 0e570670
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment