Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content
Commit e33987cc authored by Caitlin Shkuratov's avatar Caitlin Shkuratov
Browse files

[CS] Make NSSLC and NotificationListContainer singletons.

Note on the Dagger module changes: Previously, NSSLC and its
dependencies were part of CentralSurfacesComponent, so the submodules
that included NSSLC's dependencies only needed to be in
CentralSurfacesComponent. Now that NSSLC is a singleton, those
dependencies need to be available *outside* of CentralSurfacesComponent.
NotificationsModule is the logical place for them, because they're
notifications-related.

Now, when NSSLC is injected into CentralSurfacesImpl, it can pull its
dependencies from any modules that SysUI has, which includes
NotificationsModule.

Bug: 277762009
Test: compiles
Test: notifications smoke test (posting new notifs, expanding &
collapsing notifs, swiping notifs away, changing font size &
display scale)
Test: atest CentralSurfacesImplTest
Test: `m
out/soong/.intermediates/vendor/google_arc/packages/system/ArcSystemUI/ArcSystemUI-tests/android_common/kapt/kapt-sources.jar`
succeeds

Change-Id: Ia9c629c7dab06204568a4f04ab1a092db28be467
parent 80c14a30
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment