Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit dfbf1130 authored by Chandru S's avatar Chandru S
Browse files

Fixes isAnyShadeFullyExpanded state being incorrect in HUN+occluded keyguard+bouncer CUJ

isAnyShadeFullyExpanded is true when we dismiss bouncer and go back to HUN over camera launched over lockscreen, when it should be false

Root cause:
 1. When bouncer is dismissed and the HUN is still expanded, onHeightUpdated gets invoked
 2. That forces qsExpansion to be 1 when split shade is enabled
 3. Skip doing that now.

On split shade mode, use the same interpolation logic as non-split shade mode for mQsController.setExpansionHeight whenever we expand QS by swiping down on HUN.

Fixes: 411043624

Test: verified that a few split-shade HUN cujs work okay
 1. Have hun show up over launcher
 2. interact with HUN
 3. swipe down on HUN, QS panel on split shade expands normally
 4. Repeat this with HUN over app launched on lockscreen.

Test: verified older bug b/247799702 is not reproduced with this change
 1. Expand split shade
 2. Swipe to second page of QS tiles
 3. Close the shade
 4. Expand split shade again - QS is on the first page and not the second.

Test: verified manually
 1. launch camera over lockscreen
 2. receive a HUN with inline reply
 3. tap on hun
 4. go to primary bouncer
 5. authenticate and then go back to the notification over camera.
Flag: com.android.systemui.bouncer_ui_revamp
Change-Id: I2d7c5a229e46697725211b5c9f53c202441ac8dc
parent 2c2e04e6
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment