Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content
Commit d89a020d authored by Maryam Dehaini's avatar Maryam Dehaini
Browse files

Use a seperate transaction to applying windowing mode changes after

exiting pip

Currently, we always use the wct that is called during
TransitionFinishCallback#onTransitionFinished in order to apply the
windowing mode vhanges after a task exits pip. This method applies the
wct during cleanup rather than applying it in its own transition. This
means that the transition is not sent to the
FreeformTaskTransitionObserver which means, when desktop windowing is
enabled, the view model is not given the chance to create the caption
needed now that the task is out of pip. By using a seperate transition
during non-fixed rotation transitions, this view model will recieve an
onTaskInfoChange call and a caption will be added.

The reason that a separate transition is not used for fixed rotation
transitions is because a new transition will reset the orientation,
positioning, and other states which were set in the original
transition., Given that this change is only required for desktop
windowing which does not utilize fixed rotations when exiting pip, the
wct is not applied as a seperate transition for fixed rotation
transitions.

This change also changes WindowContainer#canStartChangeTransition so
that screenshots are not shown in the cleanup transition as well as the
main pip transition.

Bug: 288910069
Test: Enter pip and then return task to fullscreen. Caption should be
visible.
Flag: EXEMPT bugfix

Change-Id: I2e51880b307f201096f3d40010b61453cc596749
parent 9d2ee3f3
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment