Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d7f40594 authored by Roy Chou's avatar Roy Chou
Browse files

fix(magnification): stub mock settings controller object method in IMagnificationConnectionTest 

In some test cases we directly check isMagnificationSettingsShowing ==
false on mock MagnificationSettingsController object, but we should stub the
method to return false.

Bug: 377439255
Flag: EXEMPT bugfix
Test: atest IMagnificationConnectionTest
Change-Id: I3f6e5f5aef88580ada489b5d3c471172f43c513e
parent f24f268b

packages/SystemUI/multivalentTests/src/com/android/systemui/accessibility/IMagnificationConnectionTest.java

+2 −5
Original line number Diff line number Diff line
@@ -19,7 +19,6 @@ package com.android.systemui.accessibility; 
import static com.android.systemui.accessibility.MagnificationImpl.DELAY_SHOW_MAGNIFICATION_TIMEOUT_MS;



import static org.junit.Assert.assertEquals;

import static org.junit.Assert.assertFalse;

import static org.junit.Assert.assertNotNull;

import static org.junit.Assert.assertTrue;

import static org.mockito.ArgumentMatchers.any;
@@ -190,8 +189,7 @@ public class IMagnificationConnectionTest extends SysuiTestCase { 


    @Test

    public void showMagnificationButton_delayedShowButton() throws RemoteException {

        // magnification settings panel should not be showing

        assertFalse(mMagnification.isMagnificationSettingsPanelShowing(TEST_DISPLAY));

        when(mMagnificationSettingsController.isMagnificationSettingsShowing()).thenReturn(false);



        mIMagnificationConnection.showMagnificationButton(TEST_DISPLAY,

                Settings.Secure.ACCESSIBILITY_MAGNIFICATION_MODE_FULLSCREEN);
@@ -237,8 +235,7 @@ public class IMagnificationConnectionTest extends SysuiTestCase { 
    @Test

    public void removeMagnificationButton_delayingShowButton_doNotShowButtonAfterTimeout()

            throws RemoteException {

        // magnification settings panel should not be showing

        assertFalse(mMagnification.isMagnificationSettingsPanelShowing(TEST_DISPLAY));

        when(mMagnificationSettingsController.isMagnificationSettingsShowing()).thenReturn(false);



        mIMagnificationConnection.showMagnificationButton(TEST_DISPLAY,

                Settings.Secure.ACCESSIBILITY_MAGNIFICATION_MODE_FULLSCREEN);

packages/SystemUI/src/com/android/systemui/accessibility/MagnificationImpl.java

+2 −1
Original line number Diff line number Diff line
@@ -407,7 +407,8 @@ public class MagnificationImpl implements Magnification, CommandQueue.Callbacks 
        }

    }



    boolean isMagnificationSettingsPanelShowing(int displayId) {

    @MainThread

    private boolean isMagnificationSettingsPanelShowing(int displayId) {

        final MagnificationSettingsController magnificationSettingsController =

                mMagnificationSettingsSupplier.get(displayId);

        if (magnificationSettingsController != null) {