Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d720ccf7 authored by Taran Singh's avatar Taran Singh
Browse files

Refactor acceptStylusHandwriting to use variant. 

acceptStylusHandwriting(...) should use vairant with flags instead of
calling internal method directly.

We already have a test for acceptStylusHandwritingDelegation(..
, int flags, ..) in
StylusHandwritingTest#testHandwriting_delegateFromHomePackage,
this refactor makes the API test coverage happy.

Bug: 331548567
Test: atest StylusHandwritingTest
Change-Id: Ie5b4f127bc93cd839a155144368af500ed15447c
parent d1458a80

core/java/android/view/inputmethod/InputMethodManager.java

+4 −13
Original line number Diff line number Diff line
@@ -2532,18 +2532,6 @@ public final class InputMethodManager { 
                view, /* delegatorPackageName= */ null, /* handwritingDelegateFlags= */ 0);

    }



    private void startStylusHandwritingInternalAsync(

            @NonNull View view, @Nullable String delegatorPackageName,

            @HandwritingDelegateFlags int handwritingDelegateFlags,

            @NonNull @CallbackExecutor Executor executor, @NonNull Consumer<Boolean> callback) {

        Objects.requireNonNull(view);

        Objects.requireNonNull(executor);

        Objects.requireNonNull(callback);



        startStylusHandwritingInternal(

                view, delegatorPackageName, handwritingDelegateFlags, executor, callback);

    }



    private void sendFailureCallback(@NonNull @CallbackExecutor Executor executor,

            @NonNull Consumer<Boolean> callback) {

        if (executor == null || callback == null) {
@@ -2893,7 +2881,7 @@ public final class InputMethodManager { 
        if (Flags.homeScreenHandwritingDelegator()) {

            flags = delegateView.getHandwritingDelegateFlags();

        }

        startStylusHandwritingInternalAsync(

        acceptStylusHandwritingDelegation(

                delegateView, delegatorPackageName, flags, executor, callback);

    }
@@ -2928,6 +2916,9 @@ public final class InputMethodManager { 
            @HandwritingDelegateFlags int flags, @NonNull @CallbackExecutor Executor executor,

            @NonNull Consumer<Boolean> callback) {

        Objects.requireNonNull(delegatorPackageName);

        Objects.requireNonNull(delegateView);

        Objects.requireNonNull(executor);

        Objects.requireNonNull(callback);



        startStylusHandwritingInternal(

                delegateView, delegatorPackageName, flags, executor, callback);