Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d6897898 authored by Garfield Tan's avatar Garfield Tan
Browse files

Don't restart processes that host visible activities 

We chose to restart processes of background activities that can't handle
the new configuration changes, but the process may also host foreground
activities and by restarting the process foreground activities may also
be interrupted. Therefore we should skip restarting the process that has
visible activities as well.

Bug: 208266661
Test: atest SizeCompatTests#testResetNonVisibleActivity
Change-Id: Ifc50999ffad5640be3c6e34062786f2cc1ebf8b5
parent fd73a64b

services/core/java/com/android/server/wm/ActivityRecord.java

+2 −1
Original line number Diff line number Diff line
@@ -7981,7 +7981,8 @@ final class ActivityRecord extends WindowToken implements WindowManagerService.A 
        if (mVisibleRequested) {

            // It may toggle the UI for user to restart the size compatibility mode activity.

            display.handleActivitySizeCompatModeIfNeeded(this);

        } else if (mCompatDisplayInsets != null && !visibleIgnoringKeyguard) {

        } else if (mCompatDisplayInsets != null && !visibleIgnoringKeyguard

                && (app == null || !app.hasVisibleActivities())) {

            // visibleIgnoringKeyguard is checked to avoid clearing mCompatDisplayInsets during

            // displays change. Displays are turned off during the change so mVisibleRequested

            // can be false.

services/tests/wmtests/src/com/android/server/wm/SizeCompatTests.java

+1 −0
Original line number Diff line number Diff line
@@ -535,6 +535,7 @@ public class SizeCompatTests extends WindowTestsBase { 
        mActivity.mVisibleRequested = false;

        mActivity.visibleIgnoringKeyguard = false;

        mActivity.app.setReportedProcState(ActivityManager.PROCESS_STATE_CACHED_ACTIVITY);

        mActivity.app.computeProcessActivityState();



        // Simulate the display changes orientation.

        final Configuration rotatedConfig = rotateDisplay(display, ROTATION_90);