Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d417e53b authored by Santiago Seifert's avatar Santiago Seifert
Browse files

Fix spammy logging for route discovery prefs notifications 

This change is a (mostly) non-functional change to improve logging
when the binder transaction to notify a manager of a route discovery
preference change.

Bug: 360129098
Test: Manual simple casting flow using routing demo app
Flag: EXEMPT refactor

Change-Id: Ibee1a2431c2c937bc0aaefb9fc1e451b97dd8148
parent 111c8c7b

services/core/java/com/android/server/media/MediaRouter2ServiceImpl.java

+15 −11
Original line number Diff line number Diff line
@@ -3013,6 +3013,19 @@ class MediaRouter2ServiceImpl { 
            }

        }



        /**

         * Notifies the corresponding manager that the discovery preference has changed for the

         * given {@code packageName}.

         */

        public void notifyDiscoveryPreferenceChanged(

                String packageName, RouteDiscoveryPreference preference) {

            try {

                mManager.notifyDiscoveryPreferenceChanged(packageName, preference);

            } catch (RemoteException ex) {

                logRemoteException("notifyDiscoveryPreferenceChanged", ex);

            }

        }



        /**

         * Notifies the corresponding manager that {@link RouteListingPreference} has changed for

         * the given {@code packageName}.
@@ -4056,19 +4069,10 @@ class MediaRouter2ServiceImpl { 


        private void notifyDiscoveryPreferenceChangedToManagers(@NonNull String routerPackageName,

                @Nullable RouteDiscoveryPreference discoveryPreference) {

            List<IMediaRouter2Manager> managers = new ArrayList<>();

            synchronized (mLock) {

                for (ManagerRecord managerRecord : mUserRecord.mManagerRecords) {

                    managers.add(managerRecord.mManager);

                }

            }

            for (IMediaRouter2Manager manager : managers) {

                try {

                    manager.notifyDiscoveryPreferenceChanged(routerPackageName,

                            discoveryPreference);

                } catch (RemoteException ex) {

                    Slog.w(TAG, "Failed to notify preferred features changed."

                            + " Manager probably died.", ex);

                    managerRecord.notifyDiscoveryPreferenceChanged(

                            routerPackageName, discoveryPreference);

                }

            }

        }