Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d39fd5a9 authored by Henrik Baard's avatar Henrik Baard
Browse files

Changing connect and response timeout. 

In bad network conditions and where switches often occur between 2G and
3G the timeout of 20s is too short.

Setting this timeout to 60 seconds will improve functionality in bad conditions
while it will not affect functionality in good networks. This change also aligns
the timeouts with the timeouts used by the Browser (Connection.java).

Change-Id: I0fbe3cbfe734f8d55a41bfa5d8ab6b332a19f912
parent bf1439c5

core/java/android/net/http/AndroidHttpClient.java

+7 −4
Original line number Original line Diff line number Diff line
@@ -79,6 +79,9 @@ public final class AndroidHttpClient implements HttpClient { 
    // Gzip of data shorter than this probably won't be worthwhile

    // Gzip of data shorter than this probably won't be worthwhile

    public static long DEFAULT_SYNC_MIN_GZIP_BYTES = 256;

    public static long DEFAULT_SYNC_MIN_GZIP_BYTES = 256;





    // Default connection and socket timeout of 60 seconds.  Tweak to taste.

    private static final int SOCKET_OPERATION_TIMEOUT = 60 * 1000;



    private static final String TAG = "AndroidHttpClient";

    private static final String TAG = "AndroidHttpClient";
@@ -107,9 +110,8 @@ public final class AndroidHttpClient implements HttpClient { 
        // and it's not worth it to pay the penalty of checking every time.

        // and it's not worth it to pay the penalty of checking every time.

        HttpConnectionParams.setStaleCheckingEnabled(params, false);

        HttpConnectionParams.setStaleCheckingEnabled(params, false);





        // Default connection and socket timeout of 20 seconds.  Tweak to taste.

        HttpConnectionParams.setConnectionTimeout(params, SOCKET_OPERATION_TIMEOUT);

        HttpConnectionParams.setConnectionTimeout(params, 20 * 1000);

        HttpConnectionParams.setSoTimeout(params, SOCKET_OPERATION_TIMEOUT);

        HttpConnectionParams.setSoTimeout(params, 20 * 1000);

        HttpConnectionParams.setSocketBufferSize(params, 8192);

        HttpConnectionParams.setSocketBufferSize(params, 8192);





        // Don't handle redirects -- return them to the caller.  Our code

        // Don't handle redirects -- return them to the caller.  Our code
@@ -125,7 +127,8 @@ public final class AndroidHttpClient implements HttpClient { 
        schemeRegistry.register(new Scheme("http",

        schemeRegistry.register(new Scheme("http",

                PlainSocketFactory.getSocketFactory(), 80));

                PlainSocketFactory.getSocketFactory(), 80));

        schemeRegistry.register(new Scheme("https",

        schemeRegistry.register(new Scheme("https",

                SSLCertificateSocketFactory.getHttpSocketFactory(30 * 1000, sessionCache), 443));

                SSLCertificateSocketFactory.getHttpSocketFactory(

                SOCKET_OPERATION_TIMEOUT, sessionCache), 443));





        ClientConnectionManager manager =

        ClientConnectionManager manager =

                new ThreadSafeClientConnManager(params, schemeRegistry);

                new ThreadSafeClientConnManager(params, schemeRegistry);