Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d0197ac3 authored by Hans Boehm's avatar Hans Boehm Committed by Gerrit Code Review
Browse files

Merge "Do not stack allocate RefBase object in AaptAssets::filter"

parents 2438a33e 25dfa75e
Loading
Loading
Loading
Loading
+5 −5
Original line number Diff line number Diff line
@@ -1306,8 +1306,8 @@ bail:

status_t AaptAssets::filter(Bundle* bundle)
{
    WeakResourceFilter reqFilter;
    status_t err = reqFilter.parse(bundle->getConfigurations());
    sp<WeakResourceFilter> reqFilter(new WeakResourceFilter());
    status_t err = reqFilter->parse(bundle->getConfigurations());
    if (err != NO_ERROR) {
        return err;
    }
@@ -1323,12 +1323,12 @@ status_t AaptAssets::filter(Bundle* bundle)
        preferredDensity = preferredConfig.density;
    }

    if (reqFilter.isEmpty() && preferredDensity == 0) {
    if (reqFilter->isEmpty() && preferredDensity == 0) {
        return NO_ERROR;
    }

    if (bundle->getVerbose()) {
        if (!reqFilter.isEmpty()) {
        if (!reqFilter->isEmpty()) {
            printf("Applying required filter: %s\n",
                    bundle->getConfigurations().string());
        }
@@ -1380,7 +1380,7 @@ status_t AaptAssets::filter(Bundle* bundle)
                    continue;
                }
                const ResTable_config& config(file->getGroupEntry().toParams());
                if (!reqFilter.match(config)) {
                if (!reqFilter->match(config)) {
                    if (bundle->getVerbose()) {
                        printf("Pruning unneeded resource: %s\n",
                                file->getPrintableSource().string());