Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 25dfa75e authored by Hans Boehm's avatar Hans Boehm
Browse files

Do not stack allocate RefBase object in AaptAssets::filter 

Doing so is likely to trigger log messages in the future, and will
hinder diagnosis of other problems.

Bug: 30292538
Change-Id: I2cb8c507e43d06d4afa7e35b564416c1474c81d1
parent f28f6bb2

tools/aapt/AaptAssets.cpp

+5 −5
Original line number Diff line number Diff line
@@ -1306,8 +1306,8 @@ bail: 


status_t AaptAssets::filter(Bundle* bundle)

{

    WeakResourceFilter reqFilter;

    status_t err = reqFilter.parse(bundle->getConfigurations());

    sp<WeakResourceFilter> reqFilter(new WeakResourceFilter());

    status_t err = reqFilter->parse(bundle->getConfigurations());

    if (err != NO_ERROR) {

        return err;

    }
@@ -1323,12 +1323,12 @@ status_t AaptAssets::filter(Bundle* bundle) 
        preferredDensity = preferredConfig.density;

    }



    if (reqFilter.isEmpty() && preferredDensity == 0) {

    if (reqFilter->isEmpty() && preferredDensity == 0) {

        return NO_ERROR;

    }



    if (bundle->getVerbose()) {

        if (!reqFilter.isEmpty()) {

        if (!reqFilter->isEmpty()) {

            printf("Applying required filter: %s\n",

                    bundle->getConfigurations().string());

        }
@@ -1380,7 +1380,7 @@ status_t AaptAssets::filter(Bundle* bundle) 
                    continue;

                }

                const ResTable_config& config(file->getGroupEntry().toParams());

                if (!reqFilter.match(config)) {

                if (!reqFilter->match(config)) {

                    if (bundle->getVerbose()) {

                        printf("Pruning unneeded resource: %s\n",

                                file->getPrintableSource().string());