Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cfd152e5 authored by Daniel Norman's avatar Daniel Norman
Browse files

Removes posting to a handler for onWindowInfosChanged. 

This handler post was originally added to fix an ANR in b/221497060 but
that underlying lock issue has since been resolved in b/222421815.

Now, this handler post can cause OOM in extreme cases when hundreds of
messages are posted before being handled.
It should be safe to remove given that the locking issue is resolved.

Bug: 333834990
Test: Drag app from taskbar to split screen, observe no ANR
Change-Id: I5e391bb375105f369586374e38a8980a12b449b8
parent 4487bc7f

services/accessibility/accessibility.aconfig

+10 −0
Original line number Diff line number Diff line
@@ -121,6 +121,16 @@ flag { 
    bug: "286587811"

}



flag {

    name: "remove_on_window_infos_changed_handler"

    namespace: "accessibility"

    description: "Updates onWindowInfosChanged() to run without posting to a handler."

    bug: "333834990"

    metadata {

        purpose: PURPOSE_BUGFIX

    }

}



flag {

    name: "reset_hover_event_timer_on_action_up"

    namespace: "accessibility"

services/core/java/com/android/server/wm/AccessibilityWindowsPopulator.java

+5 −1
Original line number Diff line number Diff line
@@ -150,8 +150,12 @@ public final class AccessibilityWindowsPopulator extends WindowInfosListener { 
    @Override

    public void onWindowInfosChanged(InputWindowHandle[] windowHandles,

            DisplayInfo[] displayInfos) {

        if (com.android.server.accessibility.Flags.removeOnWindowInfosChangedHandler()) {

            onWindowInfosChangedInternal(windowHandles, displayInfos);

        } else {

            mHandler.post(() -> onWindowInfosChangedInternal(windowHandles, displayInfos));

        }

    }



    private void onWindowInfosChangedInternal(InputWindowHandle[] windowHandles,

            DisplayInfo[] displayInfos) {