Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c8d07943 authored by StevenHarperUK's avatar StevenHarperUK
Browse files

Bugfix : Users with no preference wrongly see expanded 

The default state gets set to VOLUME_OVERLAY_SINGLE

This then prevents the if (choosenStyle == -1) from being triggered

Then in the ChangeOverlayStyle method, the early return is hit,
so the MORE button and Devider is never Hidden.

This only happens if a user has not got a preference stored in the settings.db

Change-Id: I2fbb039b653498a263301da8112057e98f1c5b74
parent eb3f4a1f

core/java/android/view/VolumePanel.java

+1 −1
Original line number Diff line number Diff line
@@ -250,7 +250,7 @@ public class VolumePanel extends Handler implements OnSeekBarChangeListener, Vie 
        mVoiceCapable = context.getResources().getBoolean(R.bool.config_voice_capable);



        // get the users preference

        int choosenStyle = Settings.System.getInt(context.getContentResolver(),Settings.System.MODE_VOLUME_OVERLAY, Settings.System.VOLUME_OVERLAY_SINGLE);

        int choosenStyle = Settings.System.getInt(context.getContentResolver(),Settings.System.MODE_VOLUME_OVERLAY, -1);

        // by default -1 is expected - deal with choosing the right default

        if (choosenStyle == -1) {

            if (mVoiceCapable) {