Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c5115556 authored by Christoph Studer's avatar Christoph Studer
Browse files

Prevent duplicate notifications 

Don't trust mNotificationData being sorted consistently
at all times...which it actually should. But apparently isn't.

Instead of using binary search to find the previous instance of
the notification when it's updated, use a simple linear scan.

Bug: 15589158
Change-Id: I7a09d0c64e35bd1930b8992d19da1393f4e4bb4e
parent 8f4ac9e2

services/core/java/com/android/server/notification/NotificationManagerService.java

+6 −7
Original line number Diff line number Diff line
@@ -2264,15 +2264,14 @@ public class NotificationManagerService extends SystemService { 


    // lock on mNotificationList

    int indexOfNotificationLocked(String key) {

        NotificationRecord r = mNotificationsByKey.get(key);

        if (r == null) {

            return -1;

        final int N = mNotificationList.size();

        for (int i = 0; i < N; i++) {

            if (key.equals(mNotificationList.get(i).getKey())) {

                return i;

            }

        int index = Collections.binarySearch(mNotificationList, r, mRankingComparator);

        // Guarantee to return -1 when not found.

        return (index >= 0) ? index : -1;

        }



        return -1;

    }



    private void updateNotificationPulse() {

        synchronized (mNotificationList) {