Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c404cacd authored by Svetoslav's avatar Svetoslav
Browse files

Print UI polish. 

1. Fixed an issue where input focus is given to the copies
   edit text every other time we expand the options UI. We
   want focus there only if the user touches the control.

   bug:16966145

2. Fixed the all printers list view to have item dividers
   reaching the left and right ends of the list view.

   bug:17288761

3. Fixed an issue where the user can deselect all pages
   which is not only an invalid state but also causes a crash.

   bug:17286198

4. Tweaked the minimal size of the preview in landscape on
   phone to better accomodate the page.

   bug:17288904

5. Fixed a regression introduced by a change from the UI folks.

Change-Id: Ida7dad7eea413295a840028060810b2619c616e8
parent f88c2569

packages/PrintSpooler/res/layout/print_activity.xml

+1 −0
Original line number Diff line number Diff line
@@ -27,6 +27,7 @@ 
        android:id="@+id/static_content"

        android:layout_width="fill_parent"

        android:layout_height="wrap_content"

        android:paddingStart="8dip"

        android:elevation="@dimen/preview_controls_elevation"

        android:background="?android:attr/colorPrimary">

packages/PrintSpooler/res/layout/print_activity_controls.xml

+4 −6
Original line number Diff line number Diff line
@@ -55,8 +55,7 @@ 
                    android:text="@string/label_copies">

                </TextView>



                <view

                    class="com.android.printspooler.widget.FirstFocusableEditText"

                <EditText

                    android:id="@+id/copies_edittext"

                    android:layout_width="fill_parent"

                    android:layout_height="wrap_content"
@@ -64,7 +63,7 @@ 
                    android:singleLine="true"

                    android:ellipsize="end"

                    android:inputType="numberDecimal">

                </view>

                </EditText>



            </LinearLayout>
@@ -198,8 +197,7 @@ 
                    android:visibility="visible">

                </TextView>



                <view

                    class="com.android.printspooler.widget.FirstFocusableEditText"

                <EditText

                    android:id="@+id/page_range_edittext"

                    android:layout_width="fill_parent"

                    android:layout_height="wrap_content"
@@ -208,7 +206,7 @@ 
                    android:ellipsize="end"

                    android:visibility="visible"

                    android:inputType="textNoSuggestions">

                </view>

                </EditText>



            </LinearLayout>

packages/PrintSpooler/res/layout/printer_dropdown_item.xml

+2 −2
Original line number Diff line number Diff line
@@ -17,8 +17,8 @@ 
<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"

      android:layout_width="fill_parent"

      android:layout_height="wrap_content"

      android:paddingStart="16dip"

      android:paddingEnd="16dip"

      android:paddingStart="8dip"

      android:paddingEnd="8dip"

      android:minHeight="56dip"

      android:orientation="horizontal"

      android:gravity="start|center_vertical">

packages/PrintSpooler/res/layout/select_printer_activity.xml

+0 −2
Original line number Diff line number Diff line
@@ -23,8 +23,6 @@ 
        android:id="@android:id/list"

        android:layout_width="fill_parent"

        android:layout_height="fill_parent"

        android:paddingStart="@dimen/printer_list_view_padding_start"

        android:paddingEnd="@dimen/printer_list_view_padding_end"

        android:scrollbarStyle="outsideOverlay"

        android:cacheColorHint="@android:color/transparent"

        android:scrollbarAlwaysDrawVerticalTrack="true" >

packages/PrintSpooler/res/layout/spinner_dropdown_item.xml

deleted100644 → 0
+0 −52
Original line number Diff line number Diff line 
<?xml version="1.0" encoding="utf-8"?>

<!-- Copyright (C) 2013 The Android Open Source Project



     Licensed under the Apache License, Version 2.0 (the "License");

     you may not use this file except in compliance with the License.

     You may obtain a copy of the License at



          http://www.apache.org/licenses/LICENSE-2.0



     Unless required by applicable law or agreed to in writing, software

     distributed under the License is distributed on an "AS IS" BASIS,

     WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.

     See the License for the specific language governing permissions and

     limitations under the License.

-->



<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"

    android:layout_width="fill_parent"

    android:layout_height="wrap_content"

    android:minHeight="?android:attr/listPreferredItemHeightSmall"

    android:orientation="vertical"

    android:gravity="start|center_vertical">



    <TextView

        android:id="@+id/title"

        android:layout_width="wrap_content"

        android:layout_height="wrap_content"

        style="?android:attr/spinnerDropDownItemStyle"

        android:textAppearance="?android:attr/textAppearanceMedium"

        android:textColor="?android:attr/textColorPrimary"

        android:singleLine="true"

        android:ellipsize="end"

        android:textIsSelectable="false"

        android:gravity="top|left"

        android:duplicateParentState="true">

    </TextView>



    <TextView

        android:id="@+id/subtitle"

        android:layout_width="wrap_content"

        android:layout_height="wrap_content"

        style="?android:attr/spinnerDropDownItemStyle"

        android:textAppearance="?android:attr/textAppearanceSmall"

        android:textColor="?android:attr/textColorPrimary"

        android:singleLine="true"

        android:ellipsize="end"

        android:textIsSelectable="false"

        android:visibility="gone"

        android:duplicateParentState="true">

    </TextView>



</LinearLayout>