Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content
Commit c0676da2 authored by Eric Biggers's avatar Eric Biggers
Browse files

LockSettingsService: remove ensureProfileKeystoreUnlocked()

It used to be the case that on unencrypted devices and on Full Disk
Encryption (FDE) devices, when a user was started it would immediately
be unlocked too, even if it had a lockscreen credential.

http://ag/19599753 (commit 3d5653e1) changed the flow to be the same
as on File Based Encryption (FBE) devices.  Now, users are not unlocked
until their lockscreen credential is verified.

This means that the workaround implemented by
LockSettingsService.ensureProfileKeystoreUnlocked(), which decrypted and
verified the profile password when a profile with a unified challenge
was being unlocked, is no longer necessary.  Remove it.

(Note: FDE is no longer supported anyway.  However, "no encryption" is
still supported, sort of, for device bring-up only.  This workaround
applied to both "no encryption" and FDE, so that's why the actual reason
it's no longer necessary is a bit more subtle than "this was FDE code".)

Bug: 123215607
Change-Id: I7a0b694ac9120e2e98e0a155fd53b5d590ed87af
parent 32040c16
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment