Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content
Commit ba5b1994 authored by Andreas Miko's avatar Andreas Miko
Browse files

Refactor startDismissKeyguard into KeyguardDismissTransitionInteractor

There are two issues with that method being in
KeyguardTransitionInteractor:
1. Because it references back to TransitionInteractors it creates
dependency cycles that were resolved by using dagger.Lazy (avoid where
possible)
2. KeyguardTransitionInteractor is supposed to be a source to query or
listen to the state of Keyguard Transition Framework. This violates SRP
by adding unrelated functionality that a) is not relevant to most users
of KTI (usually developers of lockscreen features that don't have deep
understanding of KTF) and b) adds a lot of noise and dependencies to the
class which makes it hard to parse and pick the relevant APIs.

Bug: b/330311871
Flag: EXEMPT refactor
Test: REFACTOR_ONLY
Change-Id: I7b7d8da15d62de6e82e678539b6439e7dff1ea3f
parent ab224625
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment