Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b9be295a authored by Tiger Huang's avatar Tiger Huang
Browse files

Prevent the focus state from getting cleared 

Before this CL, if the ViewRootImpl receives an input event after
adding the window to display before performing its first traversal,
mAttachInfo.mHasWindowFocus would be set to true in
handleWindowFocusChanged called by deliverInputEvent. And then, when
ViewRootImpl is performing its first traversal,
mAttachInfo.mHasWindowFocus would be cleared, which would make the
ViewRootImpl drop all the key events.

This CL removes the redundant logic about clearing
mAttachInfo.mHasWindowFocus during the first traversal.

Bug: 119700105
Test: atest WindowFocusTests
Change-Id: Ic35752f8e0d7cd7899f238e184bfbca3c8f7ad08
parent 1215943a

core/java/android/view/ViewRootImpl.java

+0 −1
Original line number Diff line number Diff line
@@ -1916,7 +1916,6 @@ public final class ViewRootImpl implements ViewParent, 
            // PixelFormat.hasAlpha(lp.format) || lp.format == PixelFormat.RGBX_8888

            // However, windows are now always 32 bits by default, so choose 32 bits

            mAttachInfo.mUse32BitDrawingCache = true;

            mAttachInfo.mHasWindowFocus = false;

            mAttachInfo.mWindowVisibility = viewVisibility;

            mAttachInfo.mRecomputeGlobalAttributes = false;

            mLastConfigurationFromResources.setTo(config);