Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content
Commit b8f0bd20 authored by Evan Laird's avatar Evan Laird
Browse files

Remove instance fields from MobileSignalController

MobileSignalController (MSC) was storing a few fields as instance
members on itself, and thus would lose that historical information and
make it so logs could not give the full picture of what the state was in
the past

This change makes a couple of changes to make things simpler:

1. Move all telephony data onto the MobileState object, making it so the
   full decision-making state object is stored at every historical level
2. Attach MobileState and MobileStatus directly so MobileState reads its
   fields directly from the update
3. Log only the used fields from ServiceState and SignalStrength

Things are in a much better state here, but the next step should be to
formalize the difference between the fields that get set directly from
MobileStatus, and the ones that are updated in MSC#updateTelephony

Test: atest SystemUITests
Bug: 197851948
Change-Id: Ia35a13ee36b8e41b9ca86506de56f98de4891006
parent 1bb401dd
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment