Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b8868bfb authored by Roman Birg's avatar Roman Birg
Browse files

SystemUI: fix some qs tile race conditions



Whenever setTiles() was called, we assumed all the tile animations had
finished, but if the eager beaver had grabbed a tile and dropped it on the
remove target before waiting for all the animations to complete, a lot of
assumptions are broken and crashes happen. Mainly because tiles aren't removed
from pages and we try to add them to a different page (like if they
needed to be placed a page back).

Implemented cancel for ongoing animations, which we call whenever
setTiles comes in. So all tiles should be in their proper state before
we try to cache/re-add them. Also cleaned up and documented setTiles().

Also, don't try to place the edit tile in the proper place, just add it
to the list if it's not present.

Ticket: CYNGNOS-2472, OPO-635

Change-Id: I5c066abbc16f1fe7173525ea6a8a8b39460461ae
Signed-off-by: default avatarRoman Birg <roman@cyngn.com>
(cherry picked from commit a88d902d)
parent 52e6ffde
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment