Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content
Commit b7c20172 authored by Roy Chou's avatar Roy Chou
Browse files

feat(#MagSettingsPanel): add MagnificationSettingsController to interact with...

feat(#MagSettingsPanel): add MagnificationSettingsController to interact with WindowMagnificationSetting

We separate WindowMagnificationSettings from WindowMagnificationController and use a new class MagnificationSettingsController to hold and interact with the settings panel. Besides, Use DisplayIdIndexSupplier in WindowMagnification to access MagnificationSettingsController and handle controller callbacks.

Since the WindowMagnificationSettings is split from WindowMagnificationController, WindowMagnificationController can not trigger show/hide settings panel directly. Therefore, we add onClickSettingsButton callback in WindowMagnifierCallback so that WindowMagnification could receive the button clicked event then trigger the MagnificationSettingsController to show the panel. Also, we add hideMagnificationSettingsPanel method in WindowMagnification, and it can be triggered by framwork service side (in next submitted-together cl).

Bug: 271127581
Test: manually
      atest MagnificationSettingsControllerTest
      atest WindowMagnificationAnimationControllerTest
      atest WindowMagnificationControllerTest
      atest WindowMagnificationTest
Change-Id: Ibf3de2eb00a58b8375683c6e5f1e5d4239ab8a31
parent dc8992c4
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment