Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b67d2758 authored by Miranda Kephart's avatar Miranda Kephart
Browse files

Remove text spans from clipboard UI 

Some apps set the text color by using ForegroundColorSpans. When
that text is copied, we currently preserve any existing text spans
in the clipboard UI. In the specific case of a dark mode app (using
light-colored text), this causes a visible problem because our UI's
background color is always light even in dark mode.

This change casts input text to a string before setting it in the
TextView, effectively removing spans.

Bug: 275607972
Fix: 275607972
Test: manual (visual change only)
Change-Id: Ib9feb19b99aef1c35e404bd02aaf3e0baf00d284
parent 84fd6c78

packages/SystemUI/src/com/android/systemui/clipboardoverlay/ClipboardOverlayController.java

+2 −2
Original line number Diff line number Diff line
@@ -308,7 +308,7 @@ public class ClipboardOverlayController implements ClipboardListener.ClipboardOv 
                if (model.isSensitive()) {

                    mView.showTextPreview(mContext.getString(R.string.clipboard_asterisks), true);

                } else {

                    mView.showTextPreview(model.getText(), false);

                    mView.showTextPreview(model.getText().toString(), false);

                }

                mView.setEditAccessibilityAction(true);

                mOnPreviewTapped = this::editText;
@@ -527,7 +527,7 @@ public class ClipboardOverlayController implements ClipboardListener.ClipboardOv 
    }



    private void showEditableText(CharSequence text, boolean hidden) {

        mView.showTextPreview(text, hidden);

        mView.showTextPreview(text.toString(), hidden);

        mView.setEditAccessibilityAction(true);

        mOnPreviewTapped = this::editText;

    }