Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b37f31dd authored by Vishnu Nair's avatar Vishnu Nair
Browse files

Add oneway Transaction#apply 

Allow the caller  to apply the transaction as a one way binder
call. This transaction will be applied out of order with other
transactions that are applied synchronously. This method is not
safe. It should only be used when the order does not matter. But it
may be useful to avoid swithing contexts when applying transactions
in the critical path.

Bug: 297233662
Test: presubmit
Change-Id: If9141213da605ca12cfc06e14a63d1fc8c99a1ed
parent f547072a

core/java/android/view/SurfaceControl.java

+21 −4
Original line number Diff line number Diff line
@@ -123,7 +123,8 @@ public final class SurfaceControl implements Parcelable { 
    private static native long nativeMirrorSurface(long mirrorOfObject);

    private static native long nativeCreateTransaction();

    private static native long nativeGetNativeTransactionFinalizer();

    private static native void nativeApplyTransaction(long transactionObj, boolean sync);

    private static native void nativeApplyTransaction(long transactionObj, boolean sync,

            boolean oneWay);

    private static native void nativeMergeTransaction(long transactionObj,

            long otherTransactionObj);

    private static native void nativeClearTransaction(long transactionObj);
@@ -2785,9 +2786,21 @@ public final class SurfaceControl implements Parcelable { 
         * as a new transaction.

         */

        public void apply() {

            apply(false);

            apply(/*sync*/ false);

        }



        /**

         * Applies the transaction as a one way binder call. This transaction will be applied out

         * of order with other transactions that are applied synchronously. This method is not

         * safe. It should only be used when the order does not matter.

         *

         * @hide

         */

        public void applyAsyncUnsafe() {

            apply(/*sync*/ false, /*oneWay*/ true);

        }





        /**

         * Clear the transaction object, without applying it.

         *
@@ -2817,9 +2830,13 @@ public final class SurfaceControl implements Parcelable { 
         * @hide

         */

        public void apply(boolean sync) {

            apply(sync, /*oneWay*/ false);

        }



        private void apply(boolean sync, boolean oneWay) {

            applyResizedSurfaces();

            notifyReparentedSurfaces();

            nativeApplyTransaction(mNativeObject, sync);

            nativeApplyTransaction(mNativeObject, sync, oneWay);

        }



        /**
@@ -4373,7 +4390,7 @@ public final class SurfaceControl implements Parcelable { 
        void applyGlobalTransaction(boolean sync) {

            applyResizedSurfaces();

            notifyReparentedSurfaces();

            nativeApplyTransaction(mNativeObject, sync);

            nativeApplyTransaction(mNativeObject, sync, /*oneWay*/ false);

        }



        @Override

core/jni/android_view_SurfaceControl.cpp

+4 −3
Original line number Diff line number Diff line
@@ -469,9 +469,10 @@ static void nativeSetDefaultBufferSize(JNIEnv* env, jclass clazz, jlong nativeOb 
    }

}



static void nativeApplyTransaction(JNIEnv* env, jclass clazz, jlong transactionObj, jboolean sync) {

static void nativeApplyTransaction(JNIEnv* env, jclass clazz, jlong transactionObj, jboolean sync,

                                   jboolean oneWay) {

    auto transaction = reinterpret_cast<SurfaceComposerClient::Transaction*>(transactionObj);

    transaction->apply(sync);

    transaction->apply(sync, oneWay);

}



static void nativeMergeTransaction(JNIEnv* env, jclass clazz,
@@ -2119,7 +2120,7 @@ static const JNINativeMethod sSurfaceControlMethods[] = { 
            (void*)nativeSetDefaultBufferSize},

    {"nativeCreateTransaction", "()J",

            (void*)nativeCreateTransaction },

    {"nativeApplyTransaction", "(JZ)V",

    {"nativeApplyTransaction", "(JZZ)V",

            (void*)nativeApplyTransaction },

    {"nativeGetNativeTransactionFinalizer", "()J",

            (void*)nativeGetNativeTransactionFinalizer },