Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content
Commit b2d272bd authored by Josep del Rio's avatar Josep del Rio Committed by Josep del Río
Browse files

Dismiss dialog with Escape key if closeable

At the moment the Escape key will dismiss a dialog if it's not
cancelable; however, this may not match the developer's intent,
as it is not defined in the documentation that the system may
opt to just dismiss it.

At the moment, this can still happen if the developer called
`setCanceledWhenTouchOutside(true)`, and `setCancelable(false)`
afterwards.

Escape should behave like "touching outside when possible, so
this CL implements that behavior.

Bug: 333416590
Test: Flashed on device, confirmed dialogs can still be closed
with the Escape key.
Flag: EXCEMPT bugfix

Change-Id: I7a6823744b239809024af0152eb2b77f802d851e
parent 812805e8
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment