Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b198b74c authored by Wale Ogunwale's avatar Wale Ogunwale
Browse files

Don't send SCREEN_ORIENTATION_UNSET to apps. 

SCREEN_ORIENTATION_UNSET is an internal implementation detail of how WM
now handles WindowContainer requesting a specific orientation. The
container will return SCREEN_ORIENTATION_UNSET for getOrientation method
if it should affect the device orientation under specific conditions like
when it isn't visible. However, we still want to return the requested
app orientation if someone from outside WM asked for it regardless of if
the app is visible or not.

Bug: 33067025
Test: Adding a new document in the Drive app with the scan option doesn't crash.
Change-Id: I53aee1afaa311994520f573139aea9a0d87bc8e6
parent 595a29ef

services/core/java/com/android/server/wm/AppWindowToken.java

+5 −0
Original line number Diff line number Diff line
@@ -1103,6 +1103,11 @@ class AppWindowToken extends WindowToken implements WindowManagerService.AppFree 
        return mOrientation;

    }



    /** Returns the app's preferred orientation regardless of its currently visibility state. */

    int getOrientationIgnoreVisibility() {

        return mOrientation;

    }



    @Override

    void checkAppWindowsReadyToShow() {

        if (allDrawn == mAppAnimator.allDrawn) {

services/core/java/com/android/server/wm/WindowManagerService.java

+1 −1
Original line number Diff line number Diff line
@@ -2716,7 +2716,7 @@ public class WindowManagerService extends IWindowManager.Stub 
                return SCREEN_ORIENTATION_UNSPECIFIED;

            }



            return wtoken.getOrientation();

            return wtoken.getOrientationIgnoreVisibility();

        }

    }