Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit afd5c3ee authored by Chet Haase's avatar Chet Haase
Browse files

Clear animations in DisplayLists when done 

The matrix calculated by Animations is pushed down to the native
DisplayList object, and is then used when the DL is issued to the
GL renderer. This works while the animation is running, but the end
of animations is not handled correctly. In particular, we never clear the
animation, so whatever the last frame of the animation calculated will
persist on that DisplayList object until it is recreated.

The fix is to note when we used to be animating and are no longer
doing so, taking that opportunity to push the cleared state down
to the DisplayList.

Issue #6448993 action bar -- including settings menu -- disappears on Nakasi

Change-Id: I73cdadaef40d87ccbc1beb02599c4d70506ea42b
parent 0891a897

core/java/android/view/GLES20DisplayList.java

+2 −1
Original line number Diff line number Diff line
@@ -131,7 +131,8 @@ class GLES20DisplayList extends DisplayList { 
    @Override

    public void setAnimationMatrix(Matrix matrix) {

        try {

            nSetAnimationMatrix(getNativeDisplayList(), matrix.native_instance);

            nSetAnimationMatrix(getNativeDisplayList(),

                    (matrix != null) ? matrix.native_instance : 0);

        } catch (IllegalStateException e) {

            // invalid DisplayList okay: we'll set current values the next time we render to it

        }

core/java/android/view/View.java

+27 −9
Original line number Diff line number Diff line
@@ -2128,6 +2128,13 @@ public class View implements Drawable.Callback, Drawable.Callback2, KeyEvent.Cal 
     */

    static final int ACCESSIBILITY_STATE_CHANGED = 0x00000080 << IMPORTANT_FOR_ACCESSIBILITY_SHIFT;













    /**













     * Flag indicating that view has an animation set on it. This is used to track whether an













     * animation is cleared between successive frames, in order to tell the associated













     * DisplayList to clear its animation matrix.













     */













    static final int VIEW_IS_ANIMATING_TRANSFORM = 0x10000000;



























    /* End of masks for mPrivateFlags2 */





























    static final int DRAG_MASK = DRAG_CAN_ACCEPT | DRAG_HOVERED;










@@ -12764,8 +12771,18 @@ public class View implements Drawable.Callback, Drawable.Callback2, KeyEvent.Cal













        if (a != null) {















            more = drawAnimation(parent, drawingTime, a, scalingRequired);















            concatMatrix = a.willChangeTransformationMatrix();













            if (concatMatrix) {













                mPrivateFlags2 |= VIEW_IS_ANIMATING_TRANSFORM;













            }















            transformToApply = parent.mChildTransformation;













        } else if (!useDisplayListProperties &&













        } else {













            if ((mPrivateFlags2 & VIEW_IS_ANIMATING_TRANSFORM) == VIEW_IS_ANIMATING_TRANSFORM &&













                    mDisplayList != null) {













                // No longer animating: clear out old animation matrix













                mDisplayList.setAnimationMatrix(null);













                mPrivateFlags2 &= ~VIEW_IS_ANIMATING_TRANSFORM;













            }













            if (!useDisplayListProperties &&















                    (flags & ViewGroup.FLAG_SUPPORT_STATIC_TRANSFORMATIONS) != 0) {















                final boolean hasTransform =















                        parent.getChildStaticTransformation(this, parent.mChildTransformation);









@@ -12776,6 +12793,7 @@ public class View implements Drawable.Callback, Drawable.Callback2, KeyEvent.Cal













                    concatMatrix = (transformType & Transformation.TYPE_MATRIX) != 0;















                }















            }













        }





























        concatMatrix |= !childHasIdentityMatrix;