Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit afad4c7f authored by wilsonshih's avatar wilsonshih
Browse files

Fixes opening task from Recents can be hidden. 

The opening task from Recents can be invisible because there would hide
the created leash, which should be unnecessary since the recents window
animator would handle the cross fade animation.

Test: Enable shell transition, enter recents, swipe to right-most page(
the page shows "Clear all"), then click the task and verify the task
won't become invisible during animation. Test on both NexusLauncher and
3rd-party Launcher.
Test: atest FlickerTests:OpenAppFromOverviewTest
Test: atest TaplTestsQuickstep

Change-Id: I0f7b7855de944c744190f6599ed48490f6e0d9f0
parent 028954b0

packages/SystemUI/shared/src/com/android/systemui/shared/system/RemoteTransitionCompat.java

+0 −8
Original line number Diff line number Diff line
@@ -270,7 +270,6 @@ public class RemoteTransitionCompat implements Parcelable { 
                mLeashMap.put(mOpeningLeashes.get(i), target.leash);

                t.reparent(target.leash, mInfo.getRootLeash());

                t.setLayer(target.leash, layer);

                t.hide(target.leash);

                targets[i] = target;

            }

            t.apply();
@@ -325,13 +324,6 @@ public class RemoteTransitionCompat implements Parcelable { 
                }

            } else {

                wct = null;

                if (mOpeningLeashes != null) {

                    // TODO: the launcher animation should handle this

                    for (int i = 0; i < mOpeningLeashes.size(); ++i) {

                        t.show(mOpeningLeashes.get(i));

                        t.setAlpha(mOpeningLeashes.get(i), 1.f);

                    }

                }

                if (mPipTask != null && mPipTransaction != null) {

                    t.show(mInfo.getChange(mPipTask).getLeash());

                    PictureInPictureSurfaceTransaction.apply(mPipTransaction,