Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ae097932 authored by Alejandro Nijamkin's avatar Alejandro Nijamkin
Browse files

[flexiglass] Fixes issue where LS status bar appears too late 

The status bar view would get added too late, causing the layout below
it to be pushed down vertically in a janky manner. This was happening
because of an unnecessary use of MovableElement when no other scene was
actually using the same view.

This CL fixes that by removing the MovableElement.

Fix: 352052842
Test: manually verified that the jump no longer occurs
Test: manually verified no harm done when unlocking to go to Gone and
when pulling down the shade and QS on top of the lockscreen or the Gone
scene
Flag: com.android.systemui.scene_container

Change-Id: I997cf59d805bbefa7dbdfcbfb09f44b1b982a44a
parent 5627a898

packages/SystemUI/compose/features/src/com/android/systemui/keyguard/ui/composable/section/StatusBarSection.kt

+14 −24
Original line number Diff line number Diff line
@@ -28,7 +28,6 @@ import androidx.compose.ui.Modifier 
import androidx.compose.ui.platform.LocalContext

import androidx.compose.ui.unit.dp

import androidx.compose.ui.viewinterop.AndroidView

import com.android.compose.animation.scene.ElementKey

import com.android.compose.animation.scene.SceneScope

import com.android.compose.modifiers.height

import com.android.keyguard.dagger.KeyguardStatusBarViewComponent
@@ -83,11 +82,6 @@ constructor( 
                componentFactory.build(view, provider).keyguardStatusBarViewController

            }



        MovableElement(

            key = StatusBarElementKey,

            modifier = modifier,

        ) {

            content {

        AndroidView(

            factory = {

                notificationPanelView.get().findViewById<View>(R.id.keyguard_header)?.let {
@@ -105,7 +99,3 @@ constructor( 
        )

    }

}
 
    }

}



private val StatusBarElementKey = ElementKey("StatusBar")