Only reorder bubbles if the position is different
This was be run needlessly during an insets change event while bubbles were being collapsed, this causes a jump in the animation. To fix, let's skip the reorder if it's not necessary. Additionally, the reorder code path would trigger updating the bubble positions -- this is needed after an orientation change, and was happening after the overflow was reordered as a side effect. Now that we're skipping needless reorders, this doesn't happen so a call is added to explicitly update the positions of the bubbles after the orientation change to fix it. Bug: 318704215 Test: manual - have a bubble that hides the nav bar when its opened - move the bubble to a non-default location - expand and collapse the bubble => observe when collapsing the animation looks fine - have multiple bubbles, expand them, rotate the device => observe that the positions are correct Change-Id: I6c2d83d54d05260bc221c5d24622cdaaa1f7f467
Loading
Please register or sign in to comment