Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content
Commit aa441f5e authored by Mateusz Cicheński's avatar Mateusz Cicheński
Browse files

Remove the scaling code

This causes a conflict with PipTransition code that is unaware of the
scaling factor being applied. Due to the order of actions the PipBounds
are being updated first in onDisplayChangedUnchecked() with the scale,
and later on in the PipTransition.startAnimation for unhandled case.

That latter call uses the pipChange.getEndAbsBounds() value though,
which is different than what the scaling code set. As a result the
pipBoundsScale is being updated with new value that is smaller/bigger than previous percentage, leading to decrease/increase in PiP size upon screen rotation.

Additionally the setWindowCrop() call issued from PipTransition for some
reason does not trigger a client call to relayout, so the PiP surface
ends up not matching what the final task bounds are, which is visible
either as the PiP menu overlay being smaller than e.g. video content OR
as shadow that goes beyond the video content (and has only one rounded corner).

Finally this code also affect fixed rotation enter PiP.

Reverting that change while we figure out a better way to rescale the size.

Fixes 3 issues, removes the percentage size adjustment on fold/unfold,
and also keeps the PiP size upon screen rotation.

Bug: 322091225
Bug: 319083003
Bug: 308093519
Change-Id: I6e405a071fc306c85d722e3f546e6b0e21fd86cb
Test: manual
Flag: none
parent 00632d5d
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment