Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a920280d authored by Hongwei Wang's avatar Hongwei Wang
Browse files

Do not remove snapshot after task enters PiP 

We remove task snapshot if it is visible at the end of transition, and
when Task enters PiP, it leaves no snapshot for that Task. Therefore,
the task thumbnail in Overview would be empty, with disabled actions.

Fixing this by exempt the pip Task from auto snapshot removal.

Flag: EXEMPT bugfix
Video: http://recall/-/aaaaaabFQoRHlzixHdtY/gk4AYIZM3Vx0UIBG5EnVVQ
Bug: 340396323
Test: Swipe to Overview after dismiss PiP
Change-Id: I18d4a80bc82809f1bfa15271090c2e8249eedab3
parent 2247351e

services/core/java/com/android/server/wm/SnapshotController.java

+2 −2
Original line number Diff line number Diff line
@@ -186,11 +186,11 @@ class SnapshotController { 
        }

        mActivitySnapshotController.handleTransitionFinish(windows);

        mActivitySnapshotController.endSnapshotProcess();

        // Remove task snapshot if it is visible at the end of transition.

        // Remove task snapshot if it is visible at the end of transition, except for PiP.

        for (int i = changeInfos.size() - 1; i >= 0; --i) {

            final WindowContainer wc = changeInfos.get(i).mContainer;

            final Task task = wc.asTask();

            if (task != null && wc.isVisibleRequested()) {

            if (task != null && wc.isVisibleRequested() && !task.inPinnedWindowingMode()) {

                final TaskSnapshot snapshot = mTaskSnapshotController.getSnapshot(task.mTaskId,

                        task.mUserId, false /* restoreFromDisk */, false /* isLowResolution */);

                if (snapshot != null) {