Commit a50d92ea authored Feb 15, 2018 by Felipe Leme

Fixed isVisibleToUserForAutofill() so it returns true by default.

This new API was introduced during the compat app changes and it must be
implemented by views providing virtual views (like WebView). If they don't, we
need to keep the default behavior of assuming the child is visible, otherwise
we might trigger Save when the child value change and the service sets the
FLAG_SAVE_ON_ALL_VIEWS_INVISIBLE

Test: atest CtsAutoFillServiceTestCases:VirtualContainerActivityTest#testSaveNotShownWhenVirtualViewValueChanges

Fixes: 73172668

Change-Id: I80654aaffa7dd24a3b3b59e7016bd86b48fe4898

parent ee3a2ba9

core/java/android/view/View.java

+4 −1

Original line number	Diff line number	Diff line
		@@ -8807,6 +8807,9 @@ public class View implements Drawable.Callback, KeyEvent.Callback,
		/**
		* Computes whether this virtual autofill view is visible to the user.
		*
		* <p><b>Note: </b>By default it returns {@code true}, but views providing a virtual hierarchy
		* view must override it.
		*
		* @return Whether the view is visible on the screen.
		*/
		public boolean isVisibleToUserForAutofill(int virtualId) {
		@@ -8819,7 +8822,7 @@ public class View implements Drawable.Callback, KeyEvent.Callback,
		}
		}
		}
		return false;
		return true;
		}

		/**