Commit a2078ca3 authored Feb 14, 2022 by Winson Chung

Fix regression in handling of empty dark regions

- Previously LightBarController calls setIconsDarkArea(null) to indicate
  to DarkIconDispatcherImpl to set mTintArea to null and dispatch
  accordingly, but DarkIconDispatcher.isInArea(<empty rect>) would return
  true, while the updated call to send an empty list would try to iterate
  the list and check isInArea() for each rect and return false otherwise.
  To mirror the old behavior, also return true by default if there is an
  empty list.

Bug: 219387839
Bug: 208717544
Test: Open an app with light bars and verify colors change
Test: atest SystemUITests


Change-Id: I265dddafb3ee7200837f8e013f92682344c080ef

parent 59cb98e5

packages/SystemUI/plugin/src/com/android/systemui/plugins/DarkIconDispatcher.java

+3 −0

Original line number	Diff line number	Diff line
		@@ -91,6 +91,9 @@ public interface DarkIconDispatcher {
		* areas, false otherwise
		*/
		static boolean isInAreas(ArrayList<Rect> areas, View view) {
		if (areas.isEmpty()) {
		return true;
		}
		for (Rect area : areas) {
		if (isInArea(area, view)) {
		return true;