Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9f5e6b54 authored by andrewxu's avatar andrewxu Committed by Andrew Xu
Browse files

Add a function to build a header with the specified clock visibility 

This CL creates a function to build an overlay shade header with the
specified clock visibility.

Ideally, we should have a stateless function for overlay shade header,
which facilitates testing. However, it is cumbersome to implement
such a stateless function, especially when some of the overlay shade
header's children accept a view model as the param. Therefore, this
function only break up the clock visibility. It is where
"PartialStateless" in the function name comes from.

BUG: 395622173
Change-Id: I0840f885fe1b332a134645f3c2ec0676017e5db8
Flag: EXEMPT refactor
parent a7a31224

packages/SystemUI/compose/features/src/com/android/systemui/shade/ui/composable/ShadeHeader.kt

+20 −1
Original line number Diff line number Diff line
@@ -292,6 +292,25 @@ fun ContentScope.ExpandedShadeHeader( 
fun ContentScope.OverlayShadeHeader(

    viewModel: ShadeHeaderViewModel,

    modifier: Modifier = Modifier,

) {

    OverlayShadeHeaderPartialStateless(

        viewModel,

        viewModel.showClock,

        modifier,

    )

}



/**

 * Ideally, we should have a stateless function for overlay shade header, which facilitates testing.

 * However, it is cumbersome to implement such a stateless function, especially when some of the

 * overlay shade header's children accept a view model as the param. Therefore, this function only

 * break up the clock visibility. It is where "PartialStateless" comes from.

 */

@Composable

fun ContentScope.OverlayShadeHeaderPartialStateless(

    viewModel: ShadeHeaderViewModel,

    showClock: Boolean,

    modifier: Modifier = Modifier,

) {

    val horizontalPadding =

        max(LocalScreenCornerRadius.current / 2f, Shade.Dimensions.HorizontalPadding)
@@ -308,7 +327,7 @@ fun ContentScope.OverlayShadeHeader( 
                modifier = Modifier.padding(horizontal = horizontalPadding),

            ) {

                val chipHighlight = viewModel.notificationsChipHighlight

                if (viewModel.showClock) {

                if (showClock) {

                    Clock(

                        onClick = viewModel::onClockClicked,

                        modifier = Modifier.padding(horizontal = 4.dp),