Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9e76d329 authored by Robert Carr's avatar Robert Carr
Browse files

Touch region fixes for dialogs and overlapping tasks. 

There were two errors. First the function assumes that there are only
overlapping tasks in the case of freeform, and so otherwise it is not
necessary to union the focused task back at the end (and we can just
subtract all the non focused tasks). This won't work though, as there
can be for example dialogs over the launcher from another task. We
need to always add back the focused task. Secondly, we were requiring a
task to have a top visible "main app window" e.g. TYPE_APPLICATION or
TYPE_APPLICATION_STARTING. For tasks whose only presence on screen
is a dialog this will skip them and we will ignore them one way
or another.

Bug: 26962445
Change-Id: Idd5c54082409e7c34d9fc7480908c88fb12b378b
parent a51388d6

services/core/java/com/android/server/wm/DisplayContent.java

+9 −11
Original line number Diff line number Diff line
@@ -364,8 +364,8 @@ class DisplayContent { 
            final ArrayList<Task> tasks = stack.getTasks();

            for (int taskNdx = tasks.size() - 1; taskNdx >= 0; --taskNdx) {

                final Task task = tasks.get(taskNdx);

                final WindowState win = task.getTopVisibleAppMainWindow();

                if (win == null) {

                AppWindowToken token = task.getTopVisibleAppToken();

                if (token == null || !token.isVisible()) {

                    continue;

                }
@@ -375,20 +375,18 @@ class DisplayContent { 
                 * We also remove the outside touch area for resizing for all freeform

                 * tasks (including the focused).

                 *

                 * (For freeform focused task, the below logic will first remove the enlarged

                 * area, then add back the inner area.)

                 * We save the focused task region once we find it, and add it back at the end.

                 */

                final boolean isFreeformed = task.inFreeformWorkspace();

                if (task != focusedTask || isFreeformed) {

                    task.getDimBounds(mTmpRect);

                    if (isFreeformed) {

                        // If we're removing a freeform, focused app from the exclusion region,

                        // we need to add back its touchable frame later. Remember the touchable

                        // frame now.



                if (task == focusedTask) {

                    addBackFocusedTask = true;

                    mTmpRect2.set(mTmpRect);

                }



                final boolean isFreeformed = task.inFreeformWorkspace();

                if (task != focusedTask || isFreeformed) {

                    task.getDimBounds(mTmpRect);

                    if (isFreeformed) {

                        // If the task is freeformed, enlarge the area to account for outside

                        // touch area for resize.

                        mTmpRect.inset(-delta, -delta);